Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc clean ups #227

Merged
merged 2 commits into from
May 1, 2024
Merged

misc clean ups #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
759e625
add some docs
ralexstokes May 1, 2024
cabe308
clean up stale todo comments
ralexstokes May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mev-boost-rs/src/relay_mux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ impl BlindedBlockProvider for RelayMux {
return Err(Error::NoBidPrepared(auction_request.clone()))
}

// TODO: change `value` so it does the copy internally
let mut best_bid_indices =
select_best_bids(bids.iter().map(|(_, bid)| bid.message.value()).enumerate());

Expand Down
4 changes: 4 additions & 0 deletions mev-rs/src/types/auction_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
use ethereum_consensus::primitives::{BlsPublicKey, Hash32, Slot};

/// Describes a single unique auction.
#[derive(Debug, Default, Clone, PartialEq, Eq, Hash)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct AuctionRequest {
/// Slot for the proposal
#[serde(with = "crate::serde::as_str")]
pub slot: Slot,
/// Hash of the parent block for the proposal
pub parent_hash: Hash32,
/// Public key of the proposer for the proposal
pub public_key: BlsPublicKey,
}

Expand Down
Loading