-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deneb compatibility #221
feat: add deneb compatibility #221
Conversation
|
||
// TODO: perform length checks to avoid panic on `push` | ||
for sidecar in sidecars { | ||
for commitment in &sidecar.commitments { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these nested loops are not ideal, but in the usual case should not add much overhead.
it would be nice if there was an infallible conversion from the FixedBytes<N>
to the ByteVector<N>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
add
deneb
compatibility/support.