Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameters to explicitly pass in genesis_validators_root and context #213

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Change parameters to explicitly pass in genesis_validators_root and context #213

merged 2 commits into from
Mar 26, 2024

Conversation

EchoAlice
Copy link
Contributor

No description provided.

ralexstokes
ralexstokes requested changes Mar 16, 2024
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the Root type instead of Node and also you'll need to rebase from main

mev-relay-rs/src/relay.rs Outdated Show resolved Hide resolved
mev-relay-rs/src/relay.rs Outdated Show resolved Hide resolved
ralexstokes
ralexstokes approved these changes Mar 26, 2024
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ralexstokes ralexstokes merged commit 6275cef into ralexstokes:main Mar 26, 2024
4 checks passed
@EchoAlice EchoAlice deleted the verify-block-signature branch March 26, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EchoAlice @ralexstokes