Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some lints of unused types #154

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix some lints of unused types #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mev-build-rs/src/reth_builder/bidder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use ethereum_consensus::clock::SystemClock;
use std::time::Duration;

pub enum Bid {
Continue,
Done,
}

Expand Down
4 changes: 0 additions & 4 deletions mev-build-rs/src/reth_builder/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ use thiserror::Error;
pub enum Error {
#[error("no validators registered for slot {0}")]
NoRegisteredValidatorsForSlot(Slot),
#[error("already building for identifier {0:?}")]
DuplicatebuildRequest(BuildIdentifier),
#[error("channel was unexpectedly closed")]
UnexpectedChannelClosure,
#[error("missing a build request with identifier {0}")]
MissingBuild(BuildIdentifier),
#[error("missing parent block {0}")]
Expand Down
9 changes: 3 additions & 6 deletions mev-build-rs/src/reth_builder/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,9 @@ impl<
if let Err(err) = builder.submit_bid(&id).await {
tracing::warn!(id = %id, slot=?build.context.slot, err = %err, "error submitting bid for build");
}
match bid {
Bid::Continue => {}
Bid::Done => {
builder.cancel_build(&id);
break;
}
if matches!(bid, Bid::Done) {
builder.cancel_build(&id);
break;
}
}
Ok(None) => continue,
Expand Down
Loading