Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mev-build): support multiple forks when submitting bid #135

Closed
wants to merge 3 commits into from
Closed

feat(mev-build): support multiple forks when submitting bid #135

wants to merge 3 commits into from

Conversation

chirag-bgh
Copy link
Contributor

@chirag-bgh chirag-bgh commented Sep 15, 2023 •
edited
Loading

  • Implemented retrieving Execution Payload for Bellatrix & Deneb forks

@chirag-bgh chirag-bgh marked this pull request as ready for review September 17, 2023 12:48
ralexstokes
ralexstokes reviewed Sep 18, 2023
View reviewed changes
mev-build-rs/src/reth_builder/reth_compat.rs
ExecutionPayload::Deneb(deneb_payload_bundles)
}

fn get_blob_bundles<Pool>(pool: &Pool, tx_hashes: Vec<H256>) -> BlobsBundle
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic would be encapsulated in the PayloadBuilder abstraction so we wouldn't need to pass this Pool generic around through all of this code

ralexstokes
ralexstokes reviewed Sep 18, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

we do want to do something here but let's consider the design a bit first

do you know how reth handles polymorphism of the SealedBlock type? is it just Option<T> for the relevant Ts for each fork?

@chirag-bgh
Copy link
Contributor Author

do you know how reth handles polymorphism of the SealedBlock type? is it just Option<T> for the relevant Ts for each fork?

I may not be aware of this but I think there's just one form for SealedBlock which handles all the forks

@ralexstokes
Copy link
Owner

this has partially been handled in #151

the builder API type for Deneb needs to change to support the blinded blob sidecars which I intend to do in another PR coming up soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-bgh @ralexstokes