Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BlindedBlobsBundle SSZ and deserialize signed blinded block (Deneb) #124

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Update BlindedBlobsBundle SSZ and deserialize signed blinded block (Deneb) #124

merged 7 commits into from
Sep 12, 2023

Conversation

jimmygchen
Copy link
Contributor

@jimmygchen jimmygchen commented Sep 5, 2023 •
edited
Loading

  • Update BlindedBlobsBundle SSZ, spec PR here. I've also updated BlobsBundle to keep it consistent (although it doesn't really matter because they are never signed)
  • Update handle_open_bid to deserialize Deneb variant of SignedBlindedBlockAndBlobSidecars. The try-and-fallback approach isn't really ideal, it may be worth considering a v2 endpoint with a mandatory Eth-Consensus-Version header (and perhaps SSZ support as well).
  • I also had to update the ethereum-consensus and beacon-api-client dependencies to make mev-rs work for latest deneb spec.

jimmygchen
jimmygchen commented Sep 5, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@jimmygchen jimmygchen mentioned this pull request Sep 6, 2023
Merged
2 tasks
ralexstokes
ralexstokes reviewed Sep 8, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks great!

have one ask to unify how we handle the clocks

and a question on your decoding strategy

mev-boost-rs/src/service.rs Outdated Show resolved Hide resolved
mev-build-rs/src/service.rs Outdated Show resolved Hide resolved
mev-relay-rs/src/service.rs Outdated Show resolved Hide resolved
mev-rs/src/blinded_block_provider/api/server.rs Outdated Show resolved Hide resolved
@ralexstokes ralexstokes mentioned this pull request Sep 11, 2023
Merged
ralexstokes
ralexstokes approved these changes Sep 12, 2023
View reviewed changes
Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spectacular, thanks!

mev-rs/src/blinded_block_provider/api/server.rs
Err(_) => return Err(ApiClientError::from(err).into()),
},
};
let mut block = deneb::SignedBlindedBlockAndBlobSidecars::deserialize(&block)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice!

@ralexstokes ralexstokes merged commit 893f35d into ralexstokes:main Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmygchen @ralexstokes