Skip to content

Commit

Permalink
Merge pull request #181 from ralexstokes/update-ssz
Browse files Browse the repository at this point in the history
update to latest ssz with transparent derive and alloy types
  • Loading branch information
ralexstokes authored Nov 8, 2023
2 parents d392da2 + 07b65f5 commit ffa4ab2
Show file tree
Hide file tree
Showing 7 changed files with 34 additions and 20 deletions.
33 changes: 24 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ default-members = ["bin/mev"]
version = "0.3.0"

[workspace.dependencies]
ethereum-consensus = { git = "https://github.com/ralexstokes/ethereum-consensus", rev = "6338befe3db58b74a40376ebd4330843e3c3844a" }
beacon-api-client = { git = "https://github.com/ralexstokes/ethereum-consensus", rev = "6338befe3db58b74a40376ebd4330843e3c3844a" }
ethereum-consensus = { git = "https://github.com/ralexstokes/ethereum-consensus", rev = "b9baee3f3b9fc76bd9b5bc22b78edc05446af815" }
beacon-api-client = { git = "https://github.com/ralexstokes/ethereum-consensus", rev = "b9baee3f3b9fc76bd9b5bc22b78edc05446af815" }

reth-payload-builder = { git = "https://github.com/paradigmxyz/reth", rev = "5dd5555c5c7d8e43420e273e7005b8af63a847a5" }
reth-primitives = { git = "https://github.com/paradigmxyz/reth", rev = "5dd5555c5c7d8e43420e273e7005b8af63a847a5" }
Expand Down
4 changes: 2 additions & 2 deletions mev-boost-rs/src/relay_mux.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ fn validate_bid(
// Select the most valuable bids in `bids`, breaking ties by `block_hash`
fn select_best_bids(bids: impl Iterator<Item = (usize, U256)>) -> Vec<usize> {
let (best_indices, _value) =
bids.fold((vec![], U256::zero()), |(mut best_indices, max), (index, value)| {
bids.fold((vec![], U256::ZERO), |(mut best_indices, max), (index, value)| {
match value.cmp(&max) {
Ordering::Greater => (vec![index], value),
Ordering::Equal => {
Expand Down Expand Up @@ -200,7 +200,7 @@ impl BlindedBlockProvider for RelayMux {

// TODO: change `value` so it does the copy internally
let mut best_bid_indices =
select_best_bids(bids.iter().map(|(_, bid)| bid.message.value.clone()).enumerate());
select_best_bids(bids.iter().map(|(_, bid)| bid.message.value).enumerate());

// if multiple distinct bids with same bid value, break tie by randomly picking one
let mut rng = rand::thread_rng();
Expand Down
2 changes: 1 addition & 1 deletion mev-build-rs/src/reth_builder/reth_compat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fn to_byte_vector(value: Bloom) -> ByteVector<256> {
}

pub(crate) fn to_u256(value: &U256) -> ssz_rs::U256 {
ssz_rs::U256::try_from_bytes_le(&value.to_le_bytes::<32>()).unwrap()
*value
}

pub(crate) fn to_execution_payload(value: &SealedBlock) -> ExecutionPayload {
Expand Down
5 changes: 2 additions & 3 deletions mev-relay-rs/src/relay.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,7 @@ impl Relay {
}
}
let header = to_header(&mut execution_payload)?;
let mut bid =
BuilderBid { header, value: value.clone(), public_key: self.public_key.clone() };
let mut bid = BuilderBid { header, value, public_key: self.public_key.clone() };
let signature = sign_builder_message(&mut bid, &self.secret_key, &self.context)?;
let signed_builder_bid = SignedBuilderBid { message: bid, signature };

Expand Down Expand Up @@ -572,7 +571,7 @@ impl BlindedBlockRelayer for Relay {
&signed_submission.execution_payload,
)?;
debug!(%auction_request, "validated builder submission");
(auction_request, bid_trace.value.clone(), bid_trace.builder_public_key.clone())
(auction_request, bid_trace.value, bid_trace.builder_public_key.clone())
};

signed_submission.verify_signature(&self.context)?;
Expand Down
2 changes: 1 addition & 1 deletion mev-rs/src/types/block_submission.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pub struct BidTrace {
pub value: U256,
}

#[derive(Debug, Clone)]
#[derive(Debug, Clone, SimpleSerialize)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct SignedBidSubmission {
pub message: BidTrace,
Expand Down
4 changes: 2 additions & 2 deletions mev-rs/src/types/builder_bid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use ethereum_consensus::{
};
use std::fmt;

#[derive(Debug, Clone, Merkleized)]
#[derive(Debug, Clone, SimpleSerialize)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct BuilderBid {
pub header: ExecutionPayloadHeader,
Expand All @@ -30,7 +30,7 @@ impl BuilderBid {
}
}

#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
#[derive(Debug, Clone, SimpleSerialize, serde::Serialize, serde::Deserialize)]
pub struct SignedBuilderBid {
pub message: BuilderBid,
pub signature: BlsSignature,
Expand Down

0 comments on commit ffa4ab2

Please sign in to comment.