Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINI-1736] JS SDK API for In-App Purchase #243

Merged
merged 9 commits into from
Feb 16, 2023

Conversation

rleojoseph
Copy link
Collaborator

@rleojoseph rleojoseph commented Feb 8, 2023

Description

  • This PR has the Public APIs for the miniapp
  • Sample app changes done just to make sure that the Service is working fine. Actualy Sample app changes will be done later in another ticket

Links

MINI-1736

Checklist

Copy link
Contributor

@GondiTilak GondiTilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #243 (00583a3) into master (38bbb86) will decrease coverage by 0.91%.
The diff coverage is 67.74%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   90.33%   89.42%   -0.91%     
==========================================
  Files          21       22       +1     
  Lines         569      596      +27     
  Branches       41       42       +1     
==========================================
+ Hits          514      533      +19     
- Misses         37       45       +8     
  Partials       18       18              
Impacted Files Coverage Δ
js-miniapp-bridge/src/common-bridge.ts 81.93% <60.00%> (-1.41%) ⬇️
js-miniapp-sdk/src/modules/in-app-purchase.ts 77.77% <77.77%> (ø)
js-miniapp-sdk/src/miniapp.ts 93.75% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

Copy link
Member

@Climbatize Climbatize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Climbatize Climbatize merged commit 8590d58 into rakutentech:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants