Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v1.8.0 #123

Merged
merged 1 commit into from
Apr 22, 2021
Merged

release: v1.8.0 #123

merged 1 commit into from
Apr 22, 2021

Conversation

minh-rakuten
Copy link
Contributor

Description

Update changelog and version for v1.8.0.

Checklist

  • I wrote/updated tests for new/changed code.
  • I ran yarn sdk buildSdk and yarn bridge buildBridge without issues.
  • I ran yarn sample prettify and yarn sample build without issues.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #123 (99cb224) into master (6c90205) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files           9        9           
  Lines         220      220           
  Branches       10       10           
=======================================
  Hits          120      120           
  Misses         98       98           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c90205...99cb224. Read the comment docs.

khairul-alam-licon
khairul-alam-licon approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@khairul-alam-licon khairul-alam-licon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rleojoseph
rleojoseph approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@rleojoseph rleojoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Climbatize
Climbatize approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@Climbatize Climbatize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Climbatize Climbatize merged commit 017cb9d into rakutentech:master Apr 22, 2021
Climbatize pushed a commit to Climbatize/js-miniapp that referenced this pull request May 27, 2021
@minh-rakuten @Climbatize
release: v1.8.0 (rakutentech#123)
8c6486c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khairul-alam-licon khairul-alam-licon khairul-alam-licon approved these changes

@rleojoseph rleojoseph rleojoseph approved these changes

@Climbatize Climbatize Climbatize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minh-rakuten @codecov-commenter @Climbatize @rleojoseph @khairul-alam-licon