[MALI-1050] [JS Sample App] Infinite Loading is observed on downloadi…

…ng modified Base64 data (#257) * [MALI-1050] [JS Sample App] Infinite Loading is observed on downloading modified Base64 data Updated the callback function for the download file action in the sample app to throw the error to present in sample app UI. **Link:** [MALI-1050](https://jira.rakuten-it.com/jira/browse/MALI-1050) * [MALI-1050] [JS Sample App] Infinite Loading is observed on downloading modified Base64 data Resolve prettify lint errors in the last changed files. **Link:** [MALI-1050](https://jira.rakuten-it.com/jira/browse/MALI-1050) * Update js-miniapp-sample/src/pages/file-download.js Committing the suggested changes. Co-authored-by: leojoseph.r <[email protected]> --------- Co-authored-by: leojoseph.r <[email protected]>
rakutentech · Jun 23, 2023 · 250d73c · 250d73c
1 parent 07e4a2a
commit 250d73c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/js-miniapp-sample/src/pages/file-download.js b/js-miniapp-sample/src/pages/file-download.js
@@ -127,7 +127,17 @@ const FileDownload = (props: FileDownloadProps) => {
 
   function startFileDownload(url, fileName) {
     setIsPermissionGranted(true);
-    return props.downloadFile(fileName, url, { token: 'test' });
+    return props
+      .downloadFile(fileName, url, { token: 'test' })
+      .then((downloadedFile) => {
+        console.log('FileDownloadRsponse THEN:', downloadedFile);
+        props.downloadedFile = downloadedFile;
+      })
+      .catch((error) => {
+        console.log('FileDownloadErrors CATCH:', error);
+        props.error = error;
+        props.isLoading = false;
+      });
   }
 
   function handleDownloadClick(url, fileName) {
@@ -174,7 +184,8 @@ const FileDownload = (props: FileDownloadProps) => {
         <div className={classes.info}>
           <p>
             {!isPermissionGranted && '"FILE_DOWNLOAD" permission not granted.'}
-            {props.error && props.error.message}
+            {props.error && 'Download failed: ' + props.error.message}
+            {props.downloadedFile && 'File Downloaded:' + props.downloadedFile}
           </p>
         </div>
 

diff --git a/js-miniapp-sample/src/services/filedownload/actions.js b/js-miniapp-sample/src/services/filedownload/actions.js
@@ -31,10 +31,12 @@ const requestDownloadFile = (
         return Promise.resolve(name);
       })
       .catch((error) => {
+        console.log('requestDownloadFile: CATCH BLOCK: ', error);
         dispatch({
           type: FILE_DOWNLOAD_FAILURE,
-          error,
+          error: error,
         });
+        throw error;
       });
   };
 };