Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add production logs for IAM (RMCCX-6877) #336

Open
wants to merge 9 commits into
base: feature
Choose a base branch
from

Conversation

SoumenRautray
Copy link
Contributor

@SoumenRautray SoumenRautray commented Oct 3, 2024

Description

Describe the changes in this pull request.
Explain your rationale of technical decisions you made (unless discussed before).

Links

Add public links to github issues, design documents and other relevant resources (e.g. previous discussions, platform/tool documentation etc.)

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

@rakutentech-danger-bot
Copy link
Collaborator

rakutentech-danger-bot commented Oct 3, 2024

10 Warnings
⚠️ This PR does not have any assignees yet
⚠️ Branch name "test/logTest" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Tests were not updated
⚠️ Commit message "chore: add additional logs (RMCCX-6788)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor code (RMCCX-6877)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Verb "tes" in the commit message must be in imperative tense
⚠️ Commit message "chore: test public logs (RMCCX-6877)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix bitrise error (RMCCX-6877)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: refactor logs (RMCCX-6788)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: add production Logs (RMCCX-6877)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.00%

Files changed - -
Router.swift 85.44%
SlideUpView.swift 88.51%
UITabBar+IAM.swift 91.30%
TriggerAttributesValidator.swift 91.75%
RInAppMessaging.swift 93.33%
CommonUtility.swift 94.55%
CampaignsValidator.swift 94.62%
MessageMixerService.swift 95.06%
InAppMessagingInteractor.swift 95.61%
DisplayPermissionService.swift 95.79%
AccountRepository.swift 96.43%
UserDataCache.swift 97.26%
HttpRequestable.swift 97.89%
ConfigurationService.swift 98.96%
InAppMessagingModule.swift 99.21%
SlideUpViewPresenter.swift 100.00%
CampaignRepository.swift 100.00%
ErrorReportable.swift 100.00%
CampaignDispatcher.swift 100.00%
CampaignsListManager.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Oct 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants