Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable dark background only for Modal Campaign (RMCCX-7328) #334

Merged

Conversation

SoumenRautray
Copy link
Contributor

Description

Added check for enabling dark background only for modal campaign

Links

[RMCCX-7328]

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

Copy link

@rakutentech-danger-bot
Copy link
Collaborator

4 Warnings
⚠️ This PR does not have any assignees yet
⚠️ Branch name "RMCCX-7328_modalcheck" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Tests were not updated
⚠️ Commit message "chore: enable dark background only for Modal Campaign (RMCCX-7328)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.05%

Files changed - -
FullView.swift 88.36%

Powered by xcov

Generated by 🚫 Danger

@SoumenRautray SoumenRautray merged commit ff1caae into rakutentech:feature Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants