Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clickable Image bug fix and merge master (RMCCX-7351) #330

Closed
wants to merge 5 commits into from
Closed

chore: Clickable Image bug fix and merge master (RMCCX-7351) #330

wants to merge 5 commits into from

Conversation

SoumenRautray
Copy link
Contributor

@SoumenRautray SoumenRautray commented Sep 20, 2024 •
edited
Loading

Description

Merge master to feature branch
Fix for clickable image invalid behaviour

Links

https://jira.rakuten-it.com/jira/browse/RMCCX-7351

Checklist

  • I have read the contributing guidelines
  • I have added to the changelog
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I ran fastlane ci without errors
  • All project file changes are replicated in SampleSPM/SampleSPM.xcodeproj project

@rakutentech-danger-bot
Copy link
Collaborator

rakutentech-danger-bot commented Sep 20, 2024 •
edited
Loading

7 Warnings
⚠️ This PR does not have any assignees yet
⚠️ Branch name "RMCCX-7351" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>
⚠️ Verb "addres" in the commit message must be in imperative tense
⚠️ Commit message "chore: address review comments (RMCCX-7351)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix sonarcloud error (RMCCX-7351)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: fix clickable image invalid url issue (RMCCX-7351)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)
⚠️ Commit message "chore: prepare for 8.4.0 release (RMCCX-7310)" should append ticket number(s) e.g. (SDKCF-1234, SDKCF-1235)

Current coverage for RInAppMessaging.framework is 90.00%

Files changed - -
FullViewPresenter.swift 95.81% ✅
CommonUtility.swift 99.01% ✅
Constants.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

ramesh-kuntamala
ramesh-kuntamala approved these changes Sep 20, 2024
View reviewed changes
Sources/RInAppMessaging/Views/Presenters/FullViewPresenter.swift Outdated
view?.dismiss()
}

func isValidURL(_ urlString: String) -> Bool {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add this func in utility/helper class

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramesh-kuntamala ramesh-kuntamala ramesh-kuntamala approved these changes

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan Awaiting requested review from Esakkiraja-Pothikannan Esakkiraja-Pothikannan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoumenRautray @rakutentech-danger-bot @ramesh-kuntamala