chore: refactor code and fix alignment (RMCCX-7619)

rakutentech · Dec 18, 2024 · 4fddba0 · 4fddba0
1 parent 792fc43
commit 4fddba0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/Sources/RInAppMessaging/Views/CarouselCell.swift b/Sources/RInAppMessaging/Views/CarouselCell.swift
@@ -49,14 +49,10 @@ final class CarouselCell: UICollectionViewCell {
     }
 
     func configure(with image: UIImage?, altText: String?) {
-        if let image = image {
-            imageView.image = image
-            textLabel.isHidden = true
-        } else {
-            imageView.image = image
-            imageView.isHidden = true
-            textLabel.isHidden = false
-        }
+        let hasImage = (image != nil)
+        imageView.isHidden = !hasImage
+        imageView.image = image
+        textLabel.isHidden = hasImage
         textLabel.text = altText ?? "carousel_image_load_error".localized
         setNeedsLayout()
     }

diff --git a/Tests/Tests/ReadyCampaignDispatcherSpec.swift b/Tests/Tests/ReadyCampaignDispatcherSpec.swift
@@ -206,7 +206,12 @@ class ReadyCampaignDispatcherSpec: QuickSpec {
 
                         // swiftlint:disable line_length
                         let campaign =
-                        TestHelpers.generateCampaign(id: "test", title: "title", type: .modal, test: false, hasImage: false, customJson: CustomJson(carousel: Carousel(images: ["1": ImageDetails(imgUrl: "https://static.id.rakuten.co.jp/static/com/img/id/[email protected]", link: "https://www.google.com", altText: "error loading image")])))
+                        TestHelpers.generateCampaign(id: "test",
+                                                     title: "title",
+                                                     type: .modal,
+                                                     test: false,
+                                                     hasImage: false,
+                                                     customJson: CustomJson(carousel: Carousel(images: ["1": ImageDetails(imgUrl: "https://static.id.rakuten.co.jp/static/com/img/id/[email protected]", link: "https://www.google.com", altText: "error loading image")])))
                         // swiftlint:enable line_length
 
                         campaignRepository.list = [campaign]