Minor cleanup #1108
Open
Minor cleanup #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, however I'd rather not do minor syntax cleanup across lots of source files as that makes merging a pain. |
|
I reworded the commit messages to adhere to the current commit message style in the repository, as well as split them up a bit more to make review easier. Let me know if there's anything I can do to improve on the commits so that they may be merged. As far as I can tell, there are no merge conflicts currently. |
a1346054
force-pushed
the
master
branch
2 times, most recently
from
ce92bf3
to
2580103
Compare
|
Rebased to fix some more spelling issues. If the commit that removes trailing whitespace is the problem, I can drop it. It doesn't remove all the trailing whitespace from the codebase anyway. |
This makes it easier to see what the exact differences are between the three files, as well as fixes a mix of tabs and spaces.
`which` will print, even if the command does not exist, so the test will never fail. Additionally, `which` is non-standard, and has been deprecated by debian. `command -v` is the POSIX-standardized way of testing for existence of commands, and works the same even on non-POSIX systems that implement the `command` command. `command -v` will exit with 0 and print to stdout when the command exists, and will exit with 1 and *not* print anything to stdout or stderr when the command does not exist.
The previous file had broken indentation as well as other minor differences from the file distributed by gnu.org File downloaded from: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
|
I dropped the commit that removes trailing whitespace, and added a few more spelling fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.