Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An ability to set any chart version #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export type GoogleChartPackages =
| "treemap"
| "wordtree";

export type GoogleChartVersion = "current" | "upcoming";
export type GoogleChartVersion = "current" | "upcoming" | string;

export type GoogleDataTableColumnType =
| "string"
Expand All @@ -278,7 +278,7 @@ export enum GoogleDataTableColumnRoleType {
scope = "scope",
style = "style",
tooltip = "tooltip",
domain = "domain"
domain = "domain",
}

export type GoogleDataTableColumn =
Expand Down Expand Up @@ -349,9 +349,10 @@ export type GoogleDataTable = {
getColumnPattern: (columnIndex: number) => string;
getColumnProperties: (columnIndex: number) => {};
getColumnProperty: (columnIndex: number, name: string) => any;
getColumnRange: (
columnIndex: number
) => { min: number | null; max: number | null };
getColumnRange: (columnIndex: number) => {
min: number | null;
max: number | null;
};
getColumnRole: (columnIndex: number) => GoogleDataTableColumnRoleType;
getColumnType: (columnIndex: number) => GoogleDataTableColumnType;
getDistinctValues: (columnIndex: number) => any[];
Expand Down Expand Up @@ -588,12 +589,12 @@ export type GoogleChartDashboard = {
export type ReactGoogleChartDashboardRender = ({
renderControl,
renderChart,
renderToolbar
renderToolbar,
}: {
renderControl: (
filter: ({
control,
controlProp
controlProp,
}: {
control: GoogleChartControl;
controlProp: GoogleChartControlProp;
Expand Down