Remove charteditor from default chartPackages and update docs accordi…

…ngly. #234
rakannimer · Aug 16, 2018 · 19b294d · 19b294d
1 parent 2a2cbae
commit 19b294d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-google-charts",
-  "version": "3.0.4",
+  "version": "3.0.5",
   "type": "react-component",
   "description": "react-google-charts React component",
   "main": "dist/index.cjs.js",

diff --git a/src/components/GoogleChartLoader.tsx b/src/components/GoogleChartLoader.tsx
@@ -24,16 +24,16 @@ export class GoogleChartLoader extends React.Component<Props> {
       onLoad
     } = this.props;
     windowGoogleCharts.charts.load(version || "current", {
-      packages: packages || ["corechart", "controls", "charteditor"],
+      packages: packages || ["corechart", "controls"],
       language: language || "en",
       mapsApiKey
     });
     windowGoogleCharts.charts.setOnLoadCallback(() => {
       onLoad(windowGoogleCharts);
     });
   };
-  shouldComponentUpdate() {
-    return false;
+  shouldComponentUpdate(nextProps: Props) {
+    return nextProps.chartPackages === this.props.chartPackages;
   }
   render() {
     const { onError } = this.props;

diff --git a/src/docs/ChartEditor.mdx b/src/docs/ChartEditor.mdx
@@ -54,6 +54,7 @@ import Chart from '../index'
               component.setState({chartEditor, chartWrapper, google})
               console.log("Get Chart Editor")
             }}
+            chartPackages={["corechart", "controls", "charteditor"]}
           />
         </div>
       }

diff --git a/src/docs/index.mdx b/src/docs/index.mdx
@@ -12,8 +12,6 @@ import {Playground} from 'docz'
 React Google Charts offers a declarative API to make rendering charts fun and easy.
 
 
-
-
 ## Install
 
 ```sh