Expose a space deliminated format token resolver #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every save game implementation has an $env variable that points to a file, which the build script turns into a very long `match` statement. This is poor for compile times and doesn't confer much performance improvement. The $env token resolvers are being sunset with tests and implementations expected to pull from a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every save game implementation has an $env variable that points to a file, which the build script turns into a very long
matchstatement. This is poor for compile times and doesn't confer much performance improvement.The $env token resolvers are being sunset with tests and implementations expected to pull from a file.
HOI4save tests goes from 220 to 12 seconds (closing in on 20x faster)