Target as a function

[Primajin]

Closes #1034
Related: #958, #950, #581

The idea is to pass a function to target so that one can for example create a version of semver-like target:

• return 'minor' for '^'
• return 'patch' for '~'

target: (name, [{ operator }]) => operator === '^' ? 'minor' : operator === '~' ? 'patch' : 'latest'

(with the recent introduction in #1050 of filter as a function both can be combined to filter out pinned versions and versions that start with a 0 - re: #958) to fully achieve "safe" semver like versioning 🎉

target: (name, [{ operator }]) => operator === '^' ? 'minor' : operator === '~' ? 'patch' : 'latest',
filter: (_, [{ major, operator }]) => !(major === '0' || major === undefined || operator === undefined)

[raineorshine]

So far I only pass version in as a string - could not yet wrap my head around SemVer utils though.

Use the same approach we used for filter:

filterFunction(name, semverutils.parseRange(version))

1. The tests seem to run against live npm - how do we make sure that the expected latest version never changes other than choosing an old version and hope it doesn't get bumped? Can we not instead just mock the npm response?

I currently test against a package I control, https://github.com/raineorshine/ncu-test-v2, which will always have v2 as the latest. There is a suite of test packages used for testing other types of upgrades.

I think mocking the npm response would be a much better approach. I wish I had done that from the beginning. You're welcome to use either approach.

2. I couldn't reliably run the tests locally in test/index.test.ts without running everything - it always complained that pkgData is just a plain object and has no .should.have.stuff() - how do I run them locally as single tests?

I did some digging and turns out that was a bug! I was missing chai.should() from the test file. I added it in . It should work with that.

[Primajin]

OK will bring in the changes in the coming week and then open up the PR for final review 🤞🏻

[Primajin]

Alrighty ready for review 🤞🏻 🎉

[Primajin]

One last thing - should we somehow add the two filter + target as a new param/cli option?
As in semver = true sets both - so that people don't need to come up with the two functions I posted in the top?

target: (name, [{ operator }]) => operator === '^' ? 'minor' : operator === '~' ? 'patch' : 'latest',
filter: (_, [{ major, operator }]) => !(major === '0' || major === undefined || operator === undefined)

[raineorshine]

One last thing - should we somehow add the two filter + target as a new param/cli option?
As in semver = true sets both - so that people don't need to come up with the two functions I posted in the top?

Let's discuss in a separate issue. There's a bit more complexity to that.

[raineorshine]

Published in v12.5.0

[Primajin]

Oh by focusing only on the possible errors and tests etc. - I just realized we might want to tweak the success message 🤦🏻‍♂️

Maybe when it's a function we just call it "given" --> All dependencies match the given package versions :) ?

[raineorshine]

Oops! Yes, I forgot target was used in a user message.

Let's say "target package versions":

All dependencies match the given package versions :)