Memoize viewMany. Fixes #790.

lib/constants.js

@@ -45,7 +45,4 @@ Saving partially upgraded package.json
 
 const deepPatternPrefix = '**/'
 
-const deepPerfWarning = `--deep is slow and can have performance impact when there are lot of packages!
-See https://github.com/raineorshine/npm-check-updates/pull/785 for more information!`
-
-module.exports = { deepPatternPrefix, deepPerfWarning, doctorHelpText, supportedVersionTargets }
+module.exports = { deepPatternPrefix, doctorHelpText, supportedVersionTargets }

lib/index.js

@@ -20,7 +20,7 @@ const vm = require('./versionmanager')
 const doctor = require('./doctor')
 const packageManagers = require('./package-managers')
 const { print, printJson, printUpgrades } = require('./logging')
-const { deepPatternPrefix, deepPerfWarning, doctorHelpText } = require('./constants')
+const { deepPatternPrefix, doctorHelpText } = require('./constants')
 const cliOptions = require('./cli-options')
 
 // maps package managers to package file names
@@ -439,9 +439,6 @@ async function run(options = {}) {
       return analysis
     }
     else if (options.deep) {
-      if (pkgs.length > 0) {
-        print(options, chalk.yellow(deepPerfWarning), 'warn')
-      }
       analysis = await pkgs.reduce(async (previousPromise, packageFile) => {
         const packages = await previousPromise
         // Mutate packageFile for current package

lib/package-managers/npm.js

@@ -6,6 +6,7 @@ const fs = require('fs')
 const semver = require('semver')
 const spawn = require('spawn-please')
 const pacote = require('pacote')
+const mem = require('mem')
 const libnpmconfig = require('libnpmconfig')
 const versionUtil = require('../version-util')
 const { print } = require('../logging')
@@ -112,7 +113,7 @@ async function packageAuthorChanged(packageName, currentVersion, upgradedVersion
  * @returns            Promised result
  */
 async function viewOne(packageName, field, currentVersion, { timeout } = {}) {
-  const result = await viewMany(packageName, [field], currentVersion, { timeout })
+  const result = await viewManyMemoized(packageName, [field], currentVersion, { timeout })
   return result && result[field]
 }
 
@@ -140,6 +141,12 @@ async function viewMany(packageName, fields, currentVersion, { timeout } = {}) {
   }), {})
 }
 
+/** Memoize viewMany for --deep performance. */
+const viewManyMemoized = mem(viewMany, {
+  cacheKey: ([packageName, fields, currentVersion]) =>
+    `${packageName}|${fields.join('|')}|${currentVersion}`
+})
+
 /**
  * Returns true if the node engine requirement is satisfied or not specified for a given package version.
  *
@@ -281,7 +288,7 @@ module.exports = {
    */
   async newest(packageName, currentVersion, options = {}) {
 
-    const result = await viewMany(packageName, ['time', 'versions'], currentVersion, { timeout: options.timeout })
+    const result = await viewManyMemoized(packageName, ['time', 'versions'], currentVersion, { timeout: options.timeout })
 
     const versionsSatisfyingNodeEngine = _.filter(result.versions, version => satisfiesNodeEngine(version, options.enginesNode))
       .map(o => o.version)
@@ -349,4 +356,5 @@ module.exports = {
   packageAuthorChanged,
   viewOne,
   viewMany,
+  viewManyMemoized,
 }

lib/package-managers/yarn.js

@@ -9,7 +9,7 @@ const spawn = require('spawn-please')
 const libnpmconfig = require('libnpmconfig')
 const jsonlines = require('jsonlines')
 const versionUtil = require('../version-util')
-const { viewOne, viewMany } = require('./npm.js')
+const { viewOne, viewManyMemoized } = require('./npm.js')
 
 const TIME_FIELDS = ['modified', 'created']
 
@@ -216,7 +216,7 @@ module.exports = {
    * @returns
    */
   newest(packageName, currentVersion, options = {}) {
-    return viewMany(packageName, ['time', 'versions'], currentVersion,
+    return viewManyMemoized(packageName, ['time', 'versions'], currentVersion,
       { timeout: options.timeout }).then(result => {
       const versions = doesSatisfyEnginesNode(result.versions,
         options.enginesNode)

package.json

@@ -69,6 +69,7 @@
     "jsonlines": "^0.1.1",
     "libnpmconfig": "^1.2.1",
     "lodash": "^4.17.20",
+    "mem": "^8.0.0",
     "p-map": "^4.0.0",
     "pacote": "^11.2.2",
     "parse-github-url": "^1.0.2",