Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configureSDK function with options #90

Merged
merged 3 commits into from
Oct 9, 2024
Merged

add configureSDK function with options #90

merged 3 commits into from
Oct 9, 2024

Conversation

BrodyHughes
Copy link
Member

  • adds a function that allows the SDK to pass in a custom api URL or fallback to API_BASE_URL

@brunobar79 brunobar79 self-requested a review October 8, 2024 21:23
brunobar79
brunobar79 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

sdk/src/slippage.ts Outdated Show resolved Hide resolved
@BrodyHughes @brunobar79
Update sdk/src/slippage.ts
358faea 
remove unnecessary comment

Co-authored-by: Bruno Barbieri <[email protected]>
@BrodyHughes BrodyHughes merged commit 0c8fd8a into main Oct 9, 2024
1 check passed
@BrodyHughes BrodyHughes deleted the brody/add-constructor-with-options branch October 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrodyHughes @brunobar79