Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused code, remove guardrails that cause issues with new providers #88

Merged
merged 3 commits into from
Oct 3, 2024
Merged

chore: remove unused code, remove guardrails that cause issues with new providers #88

merged 3 commits into from
Oct 3, 2024

Conversation

welps
Copy link
Member

@welps welps commented Oct 2, 2024 •
edited
Loading

  • Remove unused code (specifying swap type)
  • Remove rails that cause conflicts with Relay
  • Remove wrap/unwrap code (API will return this data instead) to reduce friction for new networks
  • Add new swap type to allow branching off wrap/unwrap paths in the app/bx
  • Add new field allowanceNeeded onto parent quote so app doesn't need to be aware of addresses

fringlesinthestreet
fringlesinthestreet approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@fringlesinthestreet fringlesinthestreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! checked on the changes on the API

@welps welps requested a review from brunobar79 October 3, 2024 18:47
@brunobar79 brunobar79 merged commit b19ae3c into main Oct 3, 2024
1 check passed
@brunobar79 brunobar79 deleted the @welps/cleanup branch October 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fringlesinthestreet fringlesinthestreet fringlesinthestreet approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@welps @brunobar79 @fringlesinthestreet