Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chains overflow on mobile #998

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Conversation

brieyla1
Copy link
Contributor

@brieyla1 brieyla1 commented Feb 2, 2023

Hey rainbow kit team,

when you have too many chains on mobile, they don't all show up, and block the "close" button from view. here is the fix. (see pictures)

The fix simply adds overflow scroll and a max width of 90vh, it should not interact with any logic whatsoever.

Current behavior
CleanShot 2023-02-02 at 20 10 51@2x

Fixed behaviour (same chains for reproduction ([...chains, ...chains, ...chains, ...chains] in ChainModal.tsx)
CleanShot 2023-02-02 at 20 12 15@2x

Thanks

@brieyla1 brieyla1 requested a review from a team as a code owner February 2, 2023 19:14
@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:22am
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:22am

@vercel
Copy link

vercel bot commented Feb 2, 2023

@brieyla1 is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@brieyla1
Copy link
Contributor Author

brieyla1 commented Feb 2, 2023

take a look @DanielSinclair :)

My client wants this updated asap...

Thank you, sorry for the rush.

@brieyla1 brieyla1 changed the title fixed too many items in chains fixed too many items in chains breaking UI on mobile (overflow) Feb 2, 2023
@DanielSinclair DanielSinclair linked an issue Feb 15, 2023 that may be closed by this pull request
1 task
@DanielSinclair
Copy link
Collaborator

Hey @brieyla1. A few refactors we'd like to see before getting this merged:

  • Let's use the .css.ts convention instead of inline styles. Checkout an example like ConnectOptions/MobileOptions.css.ts
  • Run pnpm run lint --fix to make eslint happy

@DanielSinclair DanielSinclair changed the title fixed too many items in chains breaking UI on mobile (overflow) fix: chains overflow on mobile Sep 28, 2023
@DanielSinclair
Copy link
Collaborator

Mobile Test:
IMG_7702

Desktop Tests:
Screenshot 2023-09-28 at 2 29 15 AM
Screenshot 2023-09-28 at 2 31 24 AM

@magiziz
Copy link
Contributor

magiziz commented Sep 28, 2023

Good to go 👍

Screenshot 2023-09-28 at 16 53 32 Screenshot 2023-09-28 at 16 54 05

@brieyla1 Just make sure to go for .css.ts convention and can be merged.

@DanielSinclair DanielSinclair merged commit 5b8d821 into rainbow-me:main Sep 28, 2023
@CJskii
Copy link

CJskii commented Sep 29, 2023

@DanielSinclair I run "@rainbow-me/rainbowkit": "^1.0.11", but my modal still doesn't have scroll.

I was just wondering if there's anything additional that I should enable or do to get scroll working.

@DanielSinclair
Copy link
Collaborator

@CJskii This will be released later today as 1.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Ready for final PR review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] fixed too many items in chains breaking UI on mobile (overflow)
4 participants