Wallet Groups #6314
Open
Wallet Groups #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
src/navigation/ChooseWalletGroup.tsx
Outdated
| </Text> | ||
| <Box | ||
| background="surfaceSecondaryElevated" | ||
| // shadow="12px" // TODO: adding shadow clips height (?) |
There was a problem hiding this comment.
still needs to be done? If so, can help over slack if you need assistance with this
walmat
reviewed
Dec 11, 2024
bumped this to draft @greg-schrammel. I think it's important that we confirm final design so that reviewers know what they're testing |
…et-group-when-creating-a-wallet
…mpt-user-to-choose-wallet-group-when-creating-a-wallet
greg-schrammel
commented
Dec 20, 2024
| @@ -45,7 +45,8 @@ const Container = styled(Centered).attrs({ | |||
| ? deviceHeight - contentHeight | |||
| : 0, | |||
| }), | |||
| ...(IS_ANDROID ? { borderTopLeftRadius: 30, borderTopRightRadius: 30 } : {}), | |||
| borderTopLeftRadius: 30, | |||
| borderTopRightRadius: 30, | |||
| backgroundColor: backgroundColor, | |||
There was a problem hiding this comment.
can I do this? is a square on ios if not, but only when the height is not 100% idk why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
adds ability to choose a mnemonic to derive a new account from (wallet groups)
Screen recordings / screenshots
Screen.Recording.2024-12-20.at.14.58.14.mov
What to test
test you can create new wallet groups, new accounts in these groups, and these wallets actually work (sign something)