network expansion #6149
Merged
network expansion #6149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Sep 26, 2024
| @@ -22,26 +23,27 @@ import { useSwapContext } from '../providers/swap-provider'; | |||
| import { BLANK_BASE64_PIXEL } from '@/components/DappBrowser/constants'; | |||
|
|
|||
| const networkBadges = { | |||
walmat
commented
Sep 26, 2024
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/[email protected] |
walmat
commented
Sep 26, 2024
walmat
commented
Sep 26, 2024
walmat
commented
Sep 26, 2024
| @@ -102,16 +102,17 @@ export const DEFAULT_CONFIG: RainbowConfig = { | |||
| data_endpoint: DATA_ENDPOINT || 'wss://api-v4.zerion.io', | |||
| data_origin: DATA_ORIGIN, | |||
christianbaroni
approved these changes
Sep 30, 2024
estebanmino
reviewed
Oct 1, 2024
estebanmino
reviewed
Oct 1, 2024
estebanmino
reviewed
Oct 1, 2024
| @@ -199,6 +199,7 @@ const getColorsByTheme = (darkMode?: boolean) => { | |||
| [ChainId.avalanche]: '#E84142', | |||
| [ChainId.degen]: '#A36EFD', | |||
| [ChainId.blast]: '#25292E', | |||
| [ChainId.apechain]: '#0054FA', | |||
There was a problem hiding this comment.
ok i missed this one on my PRs, is it possible to use native assets color? or maybe we're missing this color from the backend data
There was a problem hiding this comment.
Looked into this, they're different from native asset colors so I dunno. @christianbaroni any idea on this?
estebanmino
approved these changes
Oct 1, 2024
For sure! I think both would be a great addition to the network expansion work. iirc we haven't done images yet because of how shadows work in the app but I may be wrong (cc @christianbaroni) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info https://rainbowhaus.slack.com/archives/C0468CDBE75/p1727380431942769?thread_ts=1727377244.944789&cid=C0468CDBE75
Fixes APP-1886