Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weth wrapping/unwrapping on other networks #5911

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Jul 2, 2024

Fixes APP-####

What changed (plus any additional context for devs)

Same fixes as the bx

  • Fix gas limit for weth unwrapping
  • remove unnecessary approval

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-02.at.15.08.06.mp4

What to test

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good ✅

@brunobar79 brunobar79 merged commit 7ce9206 into develop Jul 3, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-weth-other-networks branch July 3, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants