Remove flashbots logic and UI

[jinchung]

Fixes BX-1704

What changed (plus any additional context for devs)

• Remove flashbots logic and UI

Screen recordings

• 2 swaps in quick succession

Screen.Recording.2024-12-08.at.2.25.52.PM.mov

What to test

Please see testing list in Linear ticket (BX-1704 as well as BX-1724)

[linear]

BX-1704 Remove flashbots from swap settings

[BrodyHughes]

QA:

Swaps: ✅

• mainnet: ✅
• superchain (OP): ✅
• L2 (Arb): ✅
• L3 (Degen / Ape): ✅

Modifying Txns:

• Speed up a txn: trying to speed up gives the “NONCE HAS ALREADY BEEN USED” popup ❌
• Cancel a txn: trying to cancel gives the “NONCE HAS ALREADY BEEN USED” popup ❌

Sends: ✅

• mainnet: ✅
• superchain (OP): ✅
• L2 (Arb): ✅
• L3 (Degen / Ape): ✅

Edge cases:

• Swaps in quick succession: while swap is pending, follow up with a swap and you get “NONCE HAS ALREADY BEEN USED” ❌
• Approve + Swap: ✅
• Send + Swap alternating: while send is pending, follow up with a swap and you get “NONCE HAS ALREADY BEEN USED” ❌

Summary:

Most functions (swap, send, approvals) when done in isolation work fine. When done in quick succession and there are pending transactions, the “Nonce has already been used” popup is often found.