Nonce management #1771
Merged
Nonce management #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
force-pushed
the
@jin/nonce-mgmt
branch
from
637518c to
d8e9f8b
Compare
jinchung
requested review from
derHowie and
BrodyHughes
and removed request for
BrodyHughes
jinchung
force-pushed
the
@jin/nonce-mgmt
branch
from
f6c6ef0 to
45463ee
Compare
derHowie
approved these changes
Dec 9, 2024
…ate in parser used from addNewTx and updateTx
…ddNewtx and updateTxn have been consolidated and a gapped nonce can be picked up
…clobbers over data during for loop
jinchung
force-pushed
the
@jin/nonce-mgmt
branch
from
5de12eb to
05d4f05
Compare
BrodyHughes
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
QA DONE!
Swaps:
- mainnet: ✅
- ERC20 > Eth: ✅
- Wrap: ✅
Modifying Txns: ✅
- Speed up a txn: ✅
- Cancel a txn: ✅
Sends: ✅
- mainnet: ✅
Edge cases:
- Swaps in quick succession that both need approves: (had insufficient gas to test this flow. Will try to catch it on release regression. Jin said she is comfortable merging.)
- Approve + Swap: ✅
- Send + Swap alternating: ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1724
Fixes BX-1720
Related to: https://github.com/rainbow-me/rainbow/pull/6277/files
What changed (plus any additional context for devs)
Screen recordings / screenshots
TODO
What to test
Mix of private mempool and public mempool transactions