Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GridPlus Lattice1 support #1538

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

feat: GridPlus Lattice1 support #1538

wants to merge 40 commits into from

Conversation

DanielSinclair
Copy link
Collaborator

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

mrcnk and others added 30 commits November 21, 2023 14:57
Copy link

socket-security bot commented May 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ethereumjs/[email protected] Transitive: network +3 1.41 MB holgerd77
npm/[email protected] environment, network +14 4.53 MB asmiller1989

View full report↗︎

Copy link

socket-security bot commented May 7, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: npx patch-package

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

github-actions bot commented May 7, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9e0f9124b0d0dc5cbe009191dfc5276918edcf34

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-224c00720d536067b9935abc4792d0179e57d87e

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ce89c5ec66326c11ff30a838891f834255ae497d

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-341a17a083f74d378dcfd4c5f6edf6c6ac17979e

@@ -0,0 +1,174 @@
import { motion } from 'framer-motion';
import { setup } from 'gridplus-sdk';
import { uniqueId } from 'lodash';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with using the function to generate the password value. uniqueId isn't cryptographically random. This means that an attacker (if they know the users deviceId) could gain access to the Rabby connection and thereby send malicious signing requests. If it's desired to manage the password on behalf of the user, I'd suggest using this method:

import { randomBytes } from 'crypto';

const password = randomBytes(16).toString('hex');

It should be sufficiently cryptographically random as well as easy to securely store on their behalf.

@DanielSinclair DanielSinclair marked this pull request as draft August 22, 2024 04:19
@DanielSinclair DanielSinclair self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants