Skip to content

Commit

Permalink
fix e2e chromedriver mismatch (#778)
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Sinclair <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
  • Loading branch information
3 people authored Jul 21, 2023
1 parent 3fd18c9 commit 849d0f7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 24 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
# CHROME TESTS
chrome-e2e:
runs-on: ubuntu-latest
timeout-minutes: 20
timeout-minutes: 23
needs: [build]
env:
DISPLAY: :0
Expand All @@ -87,6 +87,8 @@ jobs:
name: node_modules.tar.gz
- name: Unzip node_modules
run: tar xzvf node_modules.tar.gz
- name: Install latest chromedriver
run: yarn upgrade chromedriver --latest --chromedriver_version=LATEST && yarn setup
- name: Download build artifacts
uses: actions/download-artifact@v3
with:
Expand Down Expand Up @@ -115,7 +117,7 @@ jobs:
- name: Run e2e parallel (Chrome)
uses: nick-fields/retry@v2
with:
timeout_minutes: 18
timeout_minutes: 20
max_attempts: 3
command: |
export BROWSER=chrome
Expand All @@ -125,7 +127,7 @@ jobs:
- name: Run e2e serial (Chrome)
uses: nick-fields/retry@v2
with:
timeout_minutes: 18
timeout_minutes: 20
max_attempts: 3
command: |
export BROWSER=chrome
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"@vanilla-extract/webpack-plugin": "2.2.0",
"audit-ci": "6.3.0",
"browserify": "17.0.0",
"chromedriver": "113.0.0",
"chromedriver": "114.0.3",
"circular-dependency-plugin": "5.2.2",
"copy-webpack-plugin": "11.0.0",
"css-loader": "6.7.1",
Expand Down
31 changes: 11 additions & 20 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4744,16 +4744,7 @@ available-typed-arrays@^1.0.5:
resolved "https://registry.yarnpkg.com/available-typed-arrays/-/available-typed-arrays-1.0.5.tgz#92f95616501069d07d10edb2fc37d3e1c65123b7"
integrity sha512-DMD0KiN46eipeziST1LPP/STfDU0sufISXmjSgvVsoU2tqxctQeASejWcfNtxYKqETM1UxQ8sp2OrSBWpHY6sw==

axios@^1.2.1:
version "1.3.2"
resolved "https://registry.yarnpkg.com/axios/-/axios-1.3.2.tgz#7ac517f0fa3ec46e0e636223fd973713a09c72b3"
integrity sha512-1M3O703bYqYuPhbHeya5bnhpYVsDDRyQSabNja04mZtboLNSuZ4YrltestrLXfHgmzua4TpUqRiVKbiQuo2epw==
dependencies:
follow-redirects "^1.15.0"
form-data "^4.0.0"
proxy-from-env "^1.1.0"

axios@^1.3.4:
axios@^1.3.4, axios@^1.4.0:
version "1.4.0"
resolved "https://registry.yarnpkg.com/axios/-/axios-1.4.0.tgz#38a7bf1224cd308de271146038b551d725f0be1f"
integrity sha512-S4XCWMEmzvo64T9GfvQDOXgYRDJ/wsSZc7Jvdgx5u1sd0JwsuPLqb3SYmusag+edF6ziyMensPVqLTSc1PiSEA==
Expand Down Expand Up @@ -5364,14 +5355,14 @@ chrome-trace-event@^1.0.2:
resolved "https://registry.yarnpkg.com/chrome-trace-event/-/chrome-trace-event-1.0.3.tgz#1015eced4741e15d06664a957dbbf50d041e26ac"
integrity sha512-p3KULyQg4S7NIHixdwbGX+nFHkoBiA4YQmyWtjb8XngSKV124nJmRysgAeujbUVb15vh+RvFUfCPqU7rXk+hZg==

chromedriver@113.0.0:
version "113.0.0"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-113.0.0.tgz#d4855f156ee51cea4282e04aadd29fa154e44dbb"
integrity sha512-UnQlt2kPicYXVNHPzy9HfcWvEbKJjjKAEaatdcnP/lCIRwuSoZFVLH0HVDAGdbraXp3dNVhfE2Qx7gw8TnHnPw==
chromedriver@114.0.3:
version "114.0.3"
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-114.0.3.tgz#fc663f8556f08cf4d357db914c30e64847705975"
integrity sha512-Qy5kqsAUrCDwpovM5pIWFkb3X3IgJLoorigwFEDgC1boL094svny3N7yw06marJHAuyX4CE/hhd25RarIcKvKg==
dependencies:
"@testim/chrome-version" "^1.1.3"
axios "^1.2.1"
compare-versions "^5.0.1"
axios "^1.4.0"
compare-versions "^6.0.0"
extract-zip "^2.0.1"
https-proxy-agent "^5.0.1"
proxy-from-env "^1.1.0"
Expand Down Expand Up @@ -5615,10 +5606,10 @@ commander@^9.3.0:
resolved "https://registry.yarnpkg.com/commander/-/commander-9.4.0.tgz#bc4a40918fefe52e22450c111ecd6b7acce6f11c"
integrity sha512-sRPT+umqkz90UA8M1yqYfnHlZA7fF6nSphDtxeywPZ49ysjxDQybzk13CL+mXekDRG92skbcqCLVovuCusNmFw==

compare-versions@^5.0.1:
version "5.0.1"
resolved "https://registry.yarnpkg.com/compare-versions/-/compare-versions-5.0.1.tgz#14c6008436d994c3787aba38d4087fabe858555e"
integrity sha512-v8Au3l0b+Nwkp4G142JcgJFh1/TUhdxut7wzD1Nq1dyp5oa3tXaqb03EXOAB6jS4gMlalkjAUPZBMiAfKUixHQ==
compare-versions@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/compare-versions/-/compare-versions-6.0.0.tgz#a3edb527e4487bfab9a8b62ffe70cebc9b87675b"
integrity sha512-s2MzYxfRsE9f/ow8hjn7ysa7pod1xhHdQMsgiJtKx6XSNf4x2N1KG4fjrkUmXcP/e9Y2ZX4zB6sHIso0Lm6evQ==

[email protected]:
version "0.0.1"
Expand Down

0 comments on commit 849d0f7

Please sign in to comment.