[WIP] Support for building in a specific Docker network #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A question; how can I let this PR run the tests? I added some tests, hope I did not mess up the GH Actions YML; I am not the best with GH Actions. |
|
I'm ditching this and am going to create a PR for adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1057
This is my attempt, and still a work in progress (untill [WIP] is out of the PR name 😄 ).
Please note that this is my first time writing Rust, so my code might not be using the best practices or stuff the maintainers of nixpacks would like to see.
I am very much open to feedback thoughout this process.