Fixed to do force_encoding when decoding JSON.#736
Closed
masato-hi wants to merge 1 commit intorails:mainfrom
Closed
Fixed to do force_encoding when decoding JSON.#736masato-hi wants to merge 1 commit intorails:mainfrom
masato-hi wants to merge 1 commit intorails:mainfrom
Conversation
masato-hi
force-pushed
the
fix-utf8-json-decode
branch
from
8676beb to
b545688
Compare
masato-hi
force-pushed
the
fix-utf8-json-decode
branch
from
b545688 to
1f225fc
Compare
Member
|
Fixed by #738 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did.
Encode variables to UTF-8 when decoding JSON.
Ruby's ENV variable is ASCII-8BIT, so force_encoding is required when accepting values passed via ENV.
What I didn't do.
Unicode Escape when encoding.
I didn't do this because the decoding process only supports Unicode up to 4 bytes.
Related.
#735
1ed51d0#diff-c105c6f17eabaabdafb33fb6b9dccbaaf06e70daba153d42e3e72741a7ff6eccL16