Replace chromedriver-helper with webdrivers #35732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this have a changelog entry? |
|
@guilleiguaran should this have a changelog entry? I can open a PR to add one. |
|
@connorshea please do! Also I think this should be backported to 5-2-stable 🤔 |
connorshea
added a commit
to connorshea/rails
that referenced
this pull request
Apr 2, 2019
rafaelfranca
added a commit
that referenced
this pull request
Apr 2, 2019
Add Changelog entry for #35732.
|
Probably, yeah |
|
I agree this should be back ported to 5-2-stable. Having a default stack for the most recent stable Rails version (Rails 6 is still in rc1) with a deprecated gem isn't nice. I was surprised today after running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromedriver-helper is deprecated in favour of webdrivers: flavorjones/chromedriver-helper#83
Closes #35731