Apartment 4.0.0.alpha1: Complete architectural refactor with comprehensive spec coverage

.github/workflows/gem-publish.yml

@@ -21,11 +21,15 @@ jobs:
       contents: write
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - uses: ruby/setup-ruby@v1
       with:
         bundler-cache: true
         rubygems: latest
         bundler: latest
     - name: Publish to RubyGems
       uses: rubygems/release-gem@v1
+
+concurrency:
+  group: ${{ github.workflow }}
+  cancel-in-progress: true

.github/workflows/rspec_mysql_8_0.yml

@@ -17,28 +17,15 @@ jobs:
       fail-fast: false
       matrix:
         ruby_version:
-          - 3.1
           - 3.2
           - 3.3
           - 3.4
-          - jruby
         rails_version:
-          - 6_1
-          - 7_0
           - 7_1
           - 7_2
           - 8_0
-        exclude:
-          - ruby_version: jruby
-            rails_version: 7_1
-          - ruby_version: jruby
-            rails_version: 7_2
-          - ruby_version: jruby
-            rails_version: 8_0
-          - ruby_version: 3.1
-            rails_version: 8_0
     env:
-      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}${{ matrix.ruby_version == 'jruby' && '_jdbc' || '' }}_mysql.gemfile
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}_mysql.gemfile
       CI: true
       DATABASE_ENGINE: mysql
       RUBY_VERSION: ${{ matrix.ruby_version }}
@@ -58,7 +45,7 @@ jobs:
           - 3306:3306
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Ruby ${{ matrix.ruby-version }}
+      - name: Set up Ruby ${{ matrix.ruby_version }}
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -73,9 +60,7 @@ jobs:
         continue-on-error: true
         run: |
           mkdir -p ./coverage
-          bundle exec rspec --format progress \
-          --format RspecJunitFormatter -o ./coverage/test-results.xml \
-          --profile
+          bundle exec rspec
       - name: Codecov Upload
         uses: codecov/codecov-action@v4
         with:
@@ -95,3 +80,7 @@ jobs:
       - name: Notify of test failure
         if: steps.rspec-tests.outcome == 'failure'
         run: exit 1
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

.github/workflows/rspec_pg_14.yml → .github/workflows/rspec_mysql_trilogy_8_0.yml

@@ -1,4 +1,4 @@
-name: RSpec PostgreSQL 14
+name: RSpec MySQL 8.0 Trilogy Adapter
 on:
   push:
     branches:
@@ -17,56 +17,36 @@ jobs:
       fail-fast: false
       matrix:
         ruby_version:
-          - 3.1
           - 3.2
           - 3.3
           - 3.4
-          - jruby
         rails_version:
-          - 6_1
-          - 7_0
           - 7_1
           - 7_2
           - 8_0
-        exclude:
-          - ruby_version: jruby
-            rails_version: 7_1
-          - ruby_version: jruby
-            rails_version: 7_2
-          - ruby_version: jruby
-            rails_version: 8_0
-          - ruby_version: 3.1
-            rails_version: 8_0
     env:
-      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}${{ matrix.ruby_version == 'jruby' && '_jdbc' || '' }}_postgresql.gemfile
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}_mysql.gemfile
       CI: true
-      DATABASE_ENGINE: postgresql
+      DATABASE_ENGINE: mysql
+      DATABASE_ADAPTER: trilogy
       RUBY_VERSION: ${{ matrix.ruby_version }}
       RAILS_VERSION: ${{ matrix.rails_version }}
     services:
-      postgres:
-        image: postgres:14-alpine
+      mysql:
+        image: mysql:8.0
         env:
-          POSTGRES_PASSWORD: postgres
-          POSTGRES_HOST_AUTH_METHOD: trust
-          POSTGRES_DB: apartment_postgresql_test
+          MYSQL_ALLOW_EMPTY_PASSWORD: true
+          MYSQL_DATABASE: apartment_mysql_test
         options: >-
-          --health-cmd pg_isready
+          --health-cmd "mysqladmin ping"
           --health-interval 10s
           --health-timeout 5s
           --health-retries 5
         ports:
-          - 5432:5432
+          - 3306:3306
     steps:
-      - name: Install PostgreSQL client
-        run: |
-          sudo apt-get update -qq
-          sudo apt-get install -y --no-install-recommends postgresql-common
-          echo | sudo /usr/share/postgresql-common/pgdg/apt.postgresql.org.sh
-          sudo apt-get update -qq
-          sudo apt-get install -y --no-install-recommends postgresql-client-14
       - uses: actions/checkout@v4
-      - name: Set up Ruby ${{ matrix.ruby-version }}
+      - name: Set up Ruby ${{ matrix.ruby_version }}
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -81,9 +61,7 @@ jobs:
         continue-on-error: true
         run: |
           mkdir -p ./coverage
-          bundle exec rspec --format progress \
-          --format RspecJunitFormatter -o ./coverage/test-results.xml \
-          --profile
+          bundle exec rspec
       - name: Codecov Upload
         uses: codecov/codecov-action@v4
         with:
@@ -102,4 +80,8 @@ jobs:
           file: ./coverage/test-results.xml
       - name: Notify of test failure
         if: steps.rspec-tests.outcome == 'failure'
-        run: exit 1
+        run: exit 1
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

.github/workflows/rspec_pg_15.yml

@@ -17,37 +17,25 @@ jobs:
       fail-fast: false
       matrix:
         ruby_version:
-          - 3.1
           - 3.2
           - 3.3
           - 3.4
-          - jruby
         rails_version:
-          - 6_1
-          - 7_0
           - 7_1
           - 7_2
           - 8_0
-        exclude:
-          - ruby_version: jruby
-            rails_version: 7_1
-          - ruby_version: jruby
-            rails_version: 7_2
-          - ruby_version: jruby
-            rails_version: 8_0
-          - ruby_version: 3.1
-            rails_version: 8_0
     env:
-      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}${{ matrix.ruby_version == 'jruby' && '_jdbc' || '' }}_postgresql.gemfile
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}_postgresql.gemfile
       CI: true
       DATABASE_ENGINE: postgresql
       RUBY_VERSION: ${{ matrix.ruby_version }}
       RAILS_VERSION: ${{ matrix.rails_version }}
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: postgres
     services:
       postgres:
         image: postgres:15-alpine
         env:
-          POSTGRES_PASSWORD: postgres
           POSTGRES_HOST_AUTH_METHOD: trust
           POSTGRES_DB: apartment_postgresql_test
         options: >-
@@ -66,7 +54,7 @@ jobs:
           sudo apt-get update -qq
           sudo apt-get install -y --no-install-recommends postgresql-client-15
       - uses: actions/checkout@v4
-      - name: Set up Ruby ${{ matrix.ruby-version }}
+      - name: Set up Ruby ${{ matrix.ruby_version }}
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -81,9 +69,7 @@ jobs:
         continue-on-error: true
         run: |
           mkdir -p ./coverage
-          bundle exec rspec --format progress \
-          --format RspecJunitFormatter -o ./coverage/test-results.xml \
-          --profile
+          bundle exec rspec
       - name: Codecov Upload
         uses: codecov/codecov-action@v4
         with:
@@ -102,4 +88,8 @@ jobs:
           file: ./coverage/test-results.xml
       - name: Notify of test failure
         if: steps.rspec-tests.outcome == 'failure'
-        run: exit 1
+        run: exit 1
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

.github/workflows/rspec_pg_16.yml

@@ -17,36 +17,25 @@ jobs:
       fail-fast: false
       matrix:
         ruby_version:
-          - 3.1
           - 3.2
           - 3.3
           - 3.4
-          - jruby
         rails_version:
-          - 6_1
-          - 7_0
           - 7_1
           - 7_2
-        exclude:
-          - ruby_version: jruby
-            rails_version: 7_1
-          - ruby_version: jruby
-            rails_version: 7_2
-          - ruby_version: jruby
-            rails_version: 8_0
-          - ruby_version: 3.1
-            rails_version: 8_0
+          - 8_0
     env:
-      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}${{ matrix.ruby_version == 'jruby' && '_jdbc' || '' }}_postgresql.gemfile
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails_version }}_postgresql.gemfile
       CI: true
       DATABASE_ENGINE: postgresql
       RUBY_VERSION: ${{ matrix.ruby_version }}
       RAILS_VERSION: ${{ matrix.rails_version }}
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: postgres
     services:
       postgres:
         image: postgres:16-alpine
         env:
-          POSTGRES_PASSWORD: postgres
           POSTGRES_HOST_AUTH_METHOD: trust
           POSTGRES_DB: apartment_postgresql_test
         options: >-
@@ -65,7 +54,7 @@ jobs:
           sudo apt-get update -qq
           sudo apt-get install -y --no-install-recommends postgresql-client-16
       - uses: actions/checkout@v4
-      - name: Set up Ruby ${{ matrix.ruby-version }}
+      - name: Set up Ruby ${{ matrix.ruby_version }}
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby_version }}
@@ -80,9 +69,7 @@ jobs:
         continue-on-error: true
         run: |
           mkdir -p ./coverage
-          bundle exec rspec --format progress \
-          --format RspecJunitFormatter -o ./coverage/test-results.xml \
-          --profile
+          bundle exec rspec
       - name: Codecov Upload
         uses: codecov/codecov-action@v4
         with:
@@ -101,4 +88,8 @@ jobs:
           file: ./coverage/test-results.xml
       - name: Notify of test failure
         if: steps.rspec-tests.outcome == 'failure'
-        run: exit 1
+        run: exit 1
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true