Fix cant modify frozen Hash error due to rails changes

[vineelvineel]

Purpose

Latest rails has been updated to avoid repeated dup(https://github.com/rails/rails/pull/52826/files) of as_json options.

I have also had this issue last week.
Getting the following error when checking against a not match(rendering empty json array)

UsersController autocomplete with unmatched
  Failure/Error: format.json { render json: results }
  FrozenError:
    can't modify frozen Hash: {:prefixes=>["users", "application"], :template=>"autocomplete", :layout=>#<Proc:0x0000000131e8d960 /Users/admin/.rvm/gems/ruby-3.3.5@local/bundler/gems/rails-31818edb0352/actionview/lib/action_view/layouts.rb:393>, :serialization_context=>#<ActiveModelSerializers::SerializationContext:0x0000000131ecd088 @request_url="http://test.host/users/autocomplete", @query_parameters={"term"=>"unmatched"}, @url_helpers=#<Module:0x000000012cd22d00>, @default_url_options={:host=>"localhost:3000"}>, :namespace=>nil}
  # /Users/admin/.rvm/gems/ruby-3.3.5@local/gems/active_model_serializers-0.10.14/lib/active_model_serializers/adapter/attributes.rb:13:in `serializable_hash'

Changes

Using .dup so that code is not using the frozen options.

Caveats

N/A

Related GitHub issues

N/A

Additional helpful information

Related conversation in rails repository https://github.com/rails/rails/pull/52826/files#r1752237530

[chaadow]

thank you for the PR @vineelvineel

[mjankowski]

Just want to confirm that this branch resolves that frozen error issue for me in a rails 8.0.0.rc2 branch.

Curious if this will be looked at for merge?

[mrhaddad]

My test suite using this branch is green as well on a Rails 8.0.0 app.

[bf4]

Thanks, awesome! Want to add Rails 8 to CI?

[devsheva]

how can we pull this fix? doesn't make sense to release a new patch version?

[mjankowski]

how can we pull this fix?

You can do something like....

gem 'active_model_serializers', github: 'rails-api/active_model_serializers', branch: '0-10-stable'

...which will pull from branch with fix.

doesn't make sense to release a new patch version?

Presumably with this PR and the linked rails-8-CI PR both merged, this might happen soon...?

[bf4]

Presumably with this PR and the linked rails-8-CI PR both merged, this might happen soon...?

yup