Improve attribute methods generation #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
reviewed
May 31, 2024
bf4
reviewed
May 31, 2024
|
@casperisfine @byroot looks fine to merge with the comment typo fixed. Can you add a comment to the https://github.com/rails-api/active_model_serializers/blob/0-9-stable/CHANGELOG.md while there? I can release a new patch after merge if you like. |
I'm currently working through Ruby warnings in our app, and one of the
top source is from ActiveModel Serializer sub classes.
Usually they look like:
```
class SomethingSerializer < AMS
attributes :title, :body
def title # method redefinition warning
titleize
end
end
```
One solution would be to call `attributes` at the end of the method,
so that `attributes` skips defining these, but it's quite unatural.
Instead we can use the self alias trick to mark these generated
methods as OK to redefine. An alternative would be to define them
in an included module like Active Model does, but not sure if it's
worth it.
While I was at it, I improved the way these methods are generated.
casperisfine
force-pushed
the
0-9-stable-warnings
branch
from
e610936
to
a6f94c8
Compare
|
@bf4 done! |
|
@bf4 I just realized now that I forgot to ask for a release :P I'm trying to grind down our warnings again, a release would be super appreciated. |
|
@casperisfine Done. Release 0.9.13 |
|
🙇 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working through Ruby warnings in our app, and one of the top source is from ActiveModel Serializer sub classes.
Usually they look like:
One solution would be to call
attributesat the end of the method, so thatattributesskips defining these, but it's quite unatural.Instead we can use the self alias trick to mark these generated methods as OK to redefine. An alternative would be to define them in an included module like Active Model does, but not sure if it's worth it.
While I was at it, I improved the way these methods are generated.
cc @bf4