Adjusts Deserializer relationship parsing to allow links/meta keys #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows specifying links/meta keys as per spec * Ignores those keys when parsing the relationship
|
@beauby any objections? |
|
@bf4 I think this still a change that's needed - is there a reason why you closed the PR? I'm not sure the test failures are related to the changes I've made but I could update to latest |
|
@nikz Not sure how or why I closed it |
|
@bf4 slip of the mouse! No worries at all. Is there anything you need me to do on this patch? |
|
I think I'd rather replace our deserializer with the jsonapi-deserializer. There are prs for it. See #1928 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The JSON API spec allows for the relationships key to include one of
data,linksormeta.The current parsing logic for the deserialiser raises an exception unless a
datakey is present (this may have been changed after the code was written 🚄), which means that we're getting an exception on a valid JSON:API document 😭Changes
data,links, ormetaas per the spec.linksormetakeys when parsing the relationship into something to be used by Rails.Caveats
It may not be the best behaviour to ignore the keys silently - however, I'm not really sure what a useful thing to do here would be. Perhaps print a warning?
Related GitHub issues
None 😺
Additional helpful information
Thanks for the 💎, and your time reviewing this folks!