Test MonitoringService deployment with zero ServiceRegistry address #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 21 21
Lines 1468 1468
Branches 193 193
=======================================
Hits 1203 1203
Misses 226 226
Partials 39 39Continue to review full report at Codecov.
|
pirapira
changed the title
If ServiceRegistry address is zero, MonitoringService's constructor is supposed to fail. This commit adds a test for this behavior.
pirapira
force-pushed
the
service-registry-address-zero
branch
from
ae048a9 to
7e09dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
If ServiceRegistry address is zero, MonitoringService's constructor
is supposed to fail. This commit adds a test for this behavior.
This is a part of #572.
What's tricky about this PR (if any)
Web3.py does not reveal the require() message that fails during deployments. #1329
Any reviewer can check these:
python_variablePYTHON_CONSTANTAnd before "merge" all checkboxes have to be checked. If you find redundant points, remove them.