Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial application framework #1

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Initial application framework #1

merged 2 commits into from
Sep 1, 2024

Conversation

dagan
Copy link
Member

@dagan dagan commented Aug 31, 2024

This is the initial application framework with an implementation of two inspections:

  1. Network tests
  2. Storage tests

@dagan dagan self-assigned this Aug 31, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gkitfo
gkitfo approved these changes Sep 1, 2024
View reviewed changes
Copy link

@gkitfo gkitfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests passed locally and in k8s with these args: ["storage", "large:2GiB", "--base-dir=/tmp"]

@dagan dagan merged commit 0a02ac8 into develop Sep 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkitfo gkitfo gkitfo approved these changes

Assignees

@dagan dagan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagan @gkitfo