radvd: save pwnam if no user or root is passed #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If -u is not passed, or -u root is passed, the is-config-writable by own uid or own gid check is not needed, so skip the pwnam that it causes. Reference: radvd-project#165 Signed-off-by: Robin H. Johnson <[email protected]>
|
Looks good to me. Let's discuss "need info on how this is being used badly with systemd" in #165 |
|
@stappersg +1 anyway? |
|
@stappersg I think this is still valuable, because it removes the getpwnam call if the output of that call would not be used. |
|
@stappersg bump, I still think this should get merged so getpwnam is not needed if configured correctly (would also give a way to not need NSS for this at all). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If -u is not passed, or -u root is passed, the is-config-writable by own
uid or own gid check is not needed, so skip the pwnam that it causes.
Reference: #165
Signed-off-by: Robin H. Johnson [email protected]