-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dapr-sts* namespaces to be deleted to the clean-up workflow #7942
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7942 +/- ##
=======================================
Coverage 61.06% 61.07%
=======================================
Files 531 531
Lines 28061 28061
=======================================
+ Hits 17136 17138 +2
+ Misses 9428 9427 -1
+ Partials 1497 1496 -1 ☔ View full report in Codecov by Sentry. |
db06cfb
to
3b83bab
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
This new namespace was added a few weeks ago and wasn't added to the cleanup-cluster.sh. I saw this when checking the long-running cluster. Adding this namespace Signed-off-by: ytimocin <[email protected]>
3b83bab
to
6b6d811
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @ytimocin. This doesn't seem a reliable approach though. Would there be an issue if we delete all except radius-system namespace? That way we won't have to maintain a hardcoded list.
I agree with you @kachawla. We need to find a better approach for this. I will create an issue on this one tomorrow. |
|
Description
This new namespace was added a few weeks ago and wasn't added to the cleanup-cluster.sh. I saw this when checking the long-running cluster. Adding this namespace.
Type of change