Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dapr-sts* namespaces to be deleted to the clean-up workflow #7942

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ytimocin
Copy link
Contributor

Description

This new namespace was added a few weeks ago and wasn't added to the cleanup-cluster.sh. I saw this when checking the long-running cluster. Adding this namespace.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@radius-functional-tests
Copy link

radius-functional-tests bot commented Sep 19, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref db06cfb
Unique ID func2b56a31fe7
Image tag pr-func2b56a31fe7
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2b56a31fe7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2b56a31fe7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func2b56a31fe7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2b56a31fe7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

github-actions bot commented Sep 19, 2024

Unit Tests

3 366 tests  ±0   3 360 ✅ ±0   3m 54s ⏱️ ±0s
  265 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 6b6d811. ± Comparison against base commit 50c1600.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (50c1600) to head (6b6d811).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7942   +/-   ##
=======================================
  Coverage   61.06%   61.07%           
=======================================
  Files         531      531           
  Lines       28061    28061           
=======================================
+ Hits        17136    17138    +2     
+ Misses       9428     9427    -1     
+ Partials     1497     1496    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lakshmimsft
lakshmimsft previously approved these changes Sep 19, 2024
@radius-functional-tests
Copy link

radius-functional-tests bot commented Sep 19, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 3b83bab
Unique ID func4c123be972
Image tag pr-func4c123be972
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4c123be972
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4c123be972
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4c123be972
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4c123be972
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

This new namespace was added a few weeks ago and wasn't added to the cleanup-cluster.sh. I saw this when checking the long-running cluster. Adding this namespace

Signed-off-by: ytimocin <[email protected]>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Sep 19, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 6b6d811
Unique ID funcc85741c2b4
Image tag pr-funcc85741c2b4
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc85741c2b4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc85741c2b4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc85741c2b4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc85741c2b4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

@ytimocin ytimocin merged commit a7395fb into main Sep 19, 2024
31 checks passed
@ytimocin ytimocin deleted the ytimocin/clean-up/ns-update branch September 19, 2024 19:48
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @ytimocin. This doesn't seem a reliable approach though. Would there be an issue if we delete all except radius-system namespace? That way we won't have to maintain a hardcoded list.

@ytimocin
Copy link
Contributor Author

Thanks for updating this @ytimocin. This doesn't seem a reliable approach though. Would there be an issue if we delete all except radius-system namespace? That way we won't have to maintain a hardcoded list.

I agree with you @kachawla. We need to find a better approach for this. I will create an issue on this one tomorrow.

@kachawla
Copy link
Contributor

Thanks for updating this @ytimocin. This doesn't seem a reliable approach though. Would there be an issue if we delete all except radius-system namespace? That way we won't have to maintain a hardcoded list.

I agree with you @kachawla. We need to find a better approach for this. I will create an issue on this one tomorrow.

Thanks for looking into this @ytimocin! Created #7966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants