Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for connection values and secrets to resource reference pages #659

Merged
merged 21 commits into from
Aug 17, 2023
Merged

Add documentation for connection values and secrets to resource reference pages #659

merged 21 commits into from
Aug 17, 2023

Conversation

willtsai
Copy link
Contributor

@willtsai willtsai commented Aug 1, 2023 •
edited
Loading

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • [ x ] Read the contribution guide
  • [ x ] Commands include options for Linux, MacOS, and Windows within codetabs
  • [ x ] New file and folder names are globally unique
  • [ x ] Page references use shortcodes instead of markdown or URL links
  • [ x ] Images use HTML style and have alternative text
  • [ x ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Auto-generated description

🤖 Generated by Copilot at 0847dd0

Summary

📝🌐🗄️

Rewrote the section on injected values in appmodel-concept/_index.md to explain cloud-native service discovery, environment variables, and MongoDB connections better.

injected values
clarified for cloud-native
autumn leaves connect

Walkthrough

  • Rewrite section on injected values to explain cloud-native service discovery, environment variable naming, and MongoDB connection example (link)

Issue reference

Fixes: #657 #670

@willtsai willtsai added the do-not-merge Do not merge this PR label Aug 1, 2023
@willtsai willtsai requested a review from a team as a code owner August 1, 2023 22:19
@willtsai willtsai marked this pull request as draft August 1, 2023 22:19
AaronCrawfis
AaronCrawfis previously approved these changes Aug 1, 2023
View reviewed changes
@willtsai
rebase to v0.23
a8e561d 
Signed-off-by: Will Tsai <[email protected]>
@willtsai
rebase to v0.23
b577117 
Signed-off-by: Will Tsai <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@willtsai willtsai removed the do-not-merge Do not merge this PR label Aug 7, 2023
@willtsai willtsai marked this pull request as ready for review August 7, 2023 17:53
@willtsai willtsai requested a review from rynowak August 7, 2023 17:54
@willtsai
Copy link
Contributor Author

willtsai commented Aug 7, 2023

ready for review @rynowak

@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@rynowak
Copy link
Contributor

rynowak commented Aug 7, 2023

The Dapr resources also include the component name

@rynowak
Copy link
Contributor

rynowak commented Aug 8, 2023

@vishwahiremat - can you help double-check this? especially the examples

@willtsai
Copy link
Contributor Author

willtsai commented Aug 8, 2023

The Dapr resources also include the component name

ah, thanks for catching this

@willtsai
address rynowak@ feedback
ef72366 
Signed-off-by: Will Tsai <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@willtsai willtsai changed the base branch from v0.23 to edge August 14, 2023 22:31
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@willtsai
move connections content
211cd6f 
Signed-off-by: Will Tsai <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

rynowak
rynowak previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved 👍

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

AaronCrawfis
AaronCrawfis previously approved these changes Aug 17, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@github-actions
Copy link

❌ Spellcheck Failed

There are spelling errors in your PR. Visit the workflow output to see what words are failing.

Adding new words

If you are adding a new custom word refer to the docs guide

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-659.westus2.azurestaticapps.net
Password: Radiu$1234

@willtsai willtsai merged commit fefc128 into edge Aug 17, 2023
7 of 8 checks passed
@willtsai willtsai deleted the willtsai/connection-values-secrets branch August 17, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@vishwahiremat vishwahiremat Awaiting requested review from vishwahiremat

@rynowak rynowak Awaiting requested review from rynowak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for connection values and secrets to resource reference pages
3 participants
@willtsai @rynowak @AaronCrawfis