How to guide for private bicpe registry support feature. #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishwanath Hiremath <[email protected]>
willtsai
requested changes
Sep 11, 2024
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
Comment on lines
+19
to
+22
| - [rad CLI]({{< ref "installation#step-1-install-the-rad-cli" >}}) | ||
| - [Bicep VSCode extension]({{< ref "installation#step-2-install-the-vs-code-extension" >}}) | ||
| - [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) | ||
| - [Radius initialized with `rad init`]({{< ref howto-environment >}}) |
There was a problem hiding this comment.
can you confirm that all these relative paths to the other docs pages will work since this page itself isn't in the root directory? there are more similar cases below that I haven't commented, please check those as well.
There was a problem hiding this comment.
yes, i have tested it locally and all the links are accessible.
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/howto-private-bicep-registry/index.md
Outdated
Show resolved
Hide resolved
| rad deploy ./env.bicep | ||
| ``` | ||
|
|
||
| ## Done |
There was a problem hiding this comment.
Instead of this "Done" header, I recommend showing the console output they should expect to see after deploying the environment, and then below the expected output the concluding "done" sentence can follow.
Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Vishwanath Hiremath <[email protected]>
willtsai
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference