Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update menu sidebar to use official Radius icons #50

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

willtsai
Copy link
Contributor

@willtsai willtsai commented Feb 9, 2024

fixes: #43

@willtsai willtsai marked this pull request as draft February 9, 2024 00:46
@willtsai
Copy link
Contributor Author

willtsai commented Feb 9, 2024

I'm not satisfied with how it looks currently, so I've converted this to draft for now while I figure out how to resize the icons:

image

@rynowak
Copy link
Contributor

rynowak commented Feb 9, 2024

This is awesome 😍

viewBox={
props.shape === 'square'
? `0 0 ${originalHeight} ${originalHeight}`
: `0 0 ${originalWidth} ${originalHeight}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need all of the complexity here with .shape? This was needed for the "Radius" logo because the text is part of the graphic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this for in case we evolve the icons into non-square shapes in the future, but I get your point that it seems unnecessary, so I'll remove the .shape property since we don't really need it at this point.

@willtsai
Copy link
Contributor Author

willtsai commented Feb 22, 2024

I'm not satisfied with how it looks currently, so I've converted this to draft for now while I figure out how to resize the icons:

image

After removing the .shape property from all the icons and playing around with the viewbox for the radius home logo, it's much improved and ready for review now!

image

@willtsai willtsai marked this pull request as ready for review February 22, 2024 23:44
Signed-off-by: Will Tsai <[email protected]>
@rynowak rynowak merged commit 1ef3a5b into radius-project:main Feb 26, 2024
3 checks passed
@rynowak
Copy link
Contributor

rynowak commented Feb 26, 2024

Thanks @willtsai !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official Radius icons and images
2 participants