-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update menu sidebar to use official Radius icons #50
Conversation
Signed-off-by: Will Tsai <[email protected]>
This is awesome 😍 |
viewBox={ | ||
props.shape === 'square' | ||
? `0 0 ${originalHeight} ${originalHeight}` | ||
: `0 0 ${originalWidth} ${originalHeight}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need all of the complexity here with .shape
? This was needed for the "Radius" logo because the text is part of the graphic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this for in case we evolve the icons into non-square shapes in the future, but I get your point that it seems unnecessary, so I'll remove the .shape
property since we don't really need it at this point.
Signed-off-by: Will Tsai <[email protected]>
…ard-radius into use-radius-icons
Signed-off-by: Will Tsai <[email protected]>
Thanks @willtsai ! |
fixes: #43