Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource breadcrumbs #29

Merged
merged 5 commits into from
Jan 23, 2024
Merged

add resource breadcrumbs #29

merged 5 commits into from
Jan 23, 2024

Conversation

willtsai
Copy link
Contributor

@willtsai willtsai commented Jan 23, 2024

Add breadcrumbs to various pages that improves ease of navigation for users.

Introduce a new resource breadcrumbs component to direct link to the parent resources.

example screenshots:

image image image

Signed-off-by: Will Tsai <[email protected]>
@rynowak
Copy link
Contributor

rynowak commented Jan 23, 2024

I think this is a really nice improvement, but is it the right place in the UI for this?

Most backstage UI includes the breadcrumbs in the header: (See images here) backstage/backstage#3965

If can't do that do, should the breadcrumbs by above the "tabs"?

If we don't like that, then this needs more padding.

@willtsai
Copy link
Contributor Author

willtsai commented Jan 23, 2024

I think this is a really nice improvement, but is it the right place in the UI for this?

Most backstage UI includes the breadcrumbs in the header: (See images here) backstage/backstage#3965

If can't do that do, should the breadcrumbs by above the "tabs"?

If we don't like that, then this needs more padding.

@rynowak Great catch on the appearance of the breadcrumbs. I took a look at the implementation in some of the major Backstage plugins in backstage/backstage#4705, and it looks like the current positioning below "tabs" and above "infocard" is what they've used, so perhaps we can stick with this? I did follow their convention of using <Box> to fix the padding.

image image

@rynowak
Copy link
Contributor

rynowak commented Jan 23, 2024

Thanks for checking that, this looks pretty awesome 👍

@willtsai willtsai merged commit b4558e6 into radius-project:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants