-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resource breadcrumbs #29
Conversation
Signed-off-by: Will Tsai <[email protected]>
I think this is a really nice improvement, but is it the right place in the UI for this? Most backstage UI includes the breadcrumbs in the header: (See images here) backstage/backstage#3965 If can't do that do, should the breadcrumbs by above the "tabs"? If we don't like that, then this needs more padding. |
@rynowak Great catch on the appearance of the breadcrumbs. I took a look at the implementation in some of the major Backstage plugins in backstage/backstage#4705, and it looks like the current positioning below "tabs" and above "infocard" is what they've used, so perhaps we can stick with this? I did follow their convention of using |
Thanks for checking that, this looks pretty awesome 👍 |
plugins/plugin-radius/src/components/resourcebreadcrumbs/ResourceBreadcrumbs.test.tsx
Show resolved
Hide resolved
plugins/plugin-radius/src/components/resourcebreadcrumbs/ResourceBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Tsai <[email protected]>
Add breadcrumbs to various pages that improves ease of navigation for users.
Introduce a new resource breadcrumbs component to direct link to the parent resources.
example screenshots: