Update build workflow bicep #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk593
force-pushed
the
update-build-workflow-bicep
branch
5 times, most recently
from
64c0c97
to
58a4d7d
Compare
sk593
force-pushed
the
update-build-workflow-bicep
branch
from
58a4d7d
to
be1c636
Compare
lakshmimsft
reviewed
Jul 1, 2024
lakshmimsft
reviewed
Jul 1, 2024
| - name: Publish bicep types | ||
| if: github.repository == 'radius-project/bicep-types-aws' && ((startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main')) | ||
| run: | | ||
| bicep publish-provider ./artifacts/bicep/index.json --target br:${{ env.BICEP_TYPES_REGISTRY }}/aws:${{ env.REL_VERSION == 'edge' && 'latest' || env.REL_VERSION }} --force | ||
| update-types: |
There was a problem hiding this comment.
not part of this PR but i'm seeing that 'set-output' on line 103, 104 is deprecated.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
maybe we can update it in this or another PR
There was a problem hiding this comment.
Good catch, this will eventually be deleted but I updated it for now so the workflow runs fine
lakshmimsft
approved these changes
Jul 2, 2024
|
pls check all checks go through. thanks! |
sk593
force-pushed
the
update-build-workflow-bicep
branch
4 times, most recently
from
cc183e1
to
8771db2
Compare
Tested this through a PR to main first and the tests passed. Will also be tested as part of this larger PR: #43 |
sk593
force-pushed
the
update-build-workflow-bicep
branch
from
8771db2
to
b0eacb4
Compare
sk593
force-pushed
the
update-build-workflow-bicep
branch
from
be2dbe1
to
b2b2f3d
Compare
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
update-build-workflow-bicep
branch
from
b2b2f3d
to
47ad11c
Compare
sk593
commented
Jul 2, 2024
| update-types: | ||
| if: github.event_name == 'pull_request' && github.base_ref == 'main' |
There was a problem hiding this comment.
Updated so this only runs on pulls from main. We don't want this running on pushes
sk593
added a commit
that referenced
this pull request
Jul 2, 2024
* update workflows --------- Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
Jul 22, 2024
* update workflows --------- Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
Aug 6, 2024
* update workflows --------- Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
Aug 6, 2024
* Update aws generator to use bicep-types and new contract (#40) * updating aws generator to use bicep-types and new contract --------- Signed-off-by: sk593 <[email protected]> * Update build and publish workflow bicep (#45) * update workflows --------- Signed-off-by: sk593 <[email protected]> * Update publish trigger during releases (#47) * update to trigger workflow on release Signed-off-by: sk593 <[email protected]> * update to push to acr on tag creation Signed-off-by: sk593 <[email protected]> * update workflow Signed-off-by: sk593 <[email protected]> --------- Signed-off-by: sk593 <[email protected]> --------- Signed-off-by: sk593 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.