Use description markup in summary tables - #168
Open
Synchro wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I'm not sure why those 2 older commits are in here - they were merged last week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommendation summary table uses the full markup of whatever is put in
recommendationorrecommendation_summarytags, but thedescriptionanddescription_summaryused in the finding summary table do not act the same way. For the most part these sections don't have much markup in, but lists and code markup are common, and it's a pity to lose them.This is because the descriptions are inserted using
<xsl:value-of select="findingDescription" />, which strips markup. This PR changes it to<xsl:copy-of select="findingDescription/node()"/>in 2 places, and<xsl:apply-templates select="description_summary" mode="summarytable"/>in another.Tested in a real project, works nicely. Same fix applies to HTML rendering, but that doesn't get much use.