Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Nested Model Type object #21

Merged
merged 4 commits into from
May 17, 2021
Merged

Nested Model Type object #21

merged 4 commits into from
May 17, 2021

Conversation

duckontheweb
Copy link
Collaborator

@duckontheweb duckontheweb commented May 17, 2021

  • Changes the model_type field to be an object containing the following fields:
    • learning_approach - Formerly the top-level algorithm_type field
    • prediction_type - Formerly the top-level model_type field
    • description - New field that allows publisher to use free text to describe the model type

#12
#11

@batic @calebrob6

EDIT 2021-05-17: Top-level model-architecture field has been moved to model_type.architecture. Also added notes for required fields in model_type object.

@duckontheweb duckontheweb requested a review from HamedAlemo May 17, 2021 15:31
@calebrob6
Copy link
Collaborator

Other than the model_architecture it looks good to me!

@duckontheweb duckontheweb added this to the v0.1.0 milestone May 17, 2021
@duckontheweb duckontheweb merged commit 369f5ff into main May 17, 2021
@duckontheweb duckontheweb deleted the change/model-type branch May 17, 2021 19:00
This was referenced May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants