embed maps #7
Open
embed maps #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces interactive React map components with embedded iframes for documentation examples. The change transitions from using local MDX components to displaying maps via a hosted Replit development environment.
- Removes all map component imports from the MDX file
- Replaces 8 different map example components with iframe embeds pointing to a Replit instance
- Each iframe includes query parameters to specify the map type being demonstrated
| For example, here's a Radar Map displaying a marker for Radar HQ: | ||
|
|
||
| <Map /> | ||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev/" width="100%" height="500" frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
The iframe src uses a development/temporary Replit URL that contains random identifiers. This URL will likely become invalid when the development session ends, breaking the embedded maps in production documentation.
Suggested change
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev/" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://radar.com/demo/maps" width="100%" height="500" frameBorder="0" allowFullScreen /> |
| In the example below, clicking the map will place a new marker, and refit the map so all markers are visible. Clicking a marker will remove it. | ||
|
|
||
| <FitBoundsMap /> | ||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
The frameBorder attribute is deprecated in HTML5. Use CSS border styling instead: style="border: none;"
Suggested change
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=fitBounds" width="100%" height="500" style="border: none;" allowFullScreen /> |
| Add a `Marker` with a custom image to the map by specifying the image URL. | ||
|
|
||
| <CustomImageMarkerMap /> | ||
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
Consider adding sandbox and referrerpolicy attributes to the iframe for better security when embedding external content.
Suggested change
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen /> | |
| <iframe src="https://cd1ab3f1-0e7e-4e88-82a5-f03c38f8ea79-00-etyxqyxe8qo8.janeway.replit.dev?type=customImageMarker" width="100%" height="500" frameBorder="0" allowFullScreen sandbox="allow-scripts allow-same-origin" referrerpolicy="no-referrer" /> |
j949wang
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.