-
-
Couldn't load subscription status.
- Fork 3.1k
help: show core plugins in root ‘?’ dynamically; remove ‘Lc’ entry #24649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
the way to make core plugins visible shpuld be listing their help in the root help instead of exposing Lc in here imho. But we must find a fast way to make the commands created by core plugins available in their subcommands helps and thats the current blocker imho |
|
I agree with the direction. Instead of exposing Lc, I’ll surface core plugin help in the root ? and in the corresponding subcommand helps. |
Signed-off-by: Divyaranjan Sahoo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code assumes the plugin name is aligned with the commands provided in the plugin, which is not always correct. we probably need a way for core plugins to expose a help message or list of commands provided instead of relying on the name. also ideally those commands shuold be listed in the right help message. but the concern for this would be about performance when doing "?*"
| { | ||
| RListIter *iter; | ||
| RCorePlugin *pl; | ||
| int count = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just r_list_length() no need to iterate
| // TODO #7967 help refactor | ||
| r_core_cmd_help (core, help_msg_intro); | ||
| r_core_cmd_help (core, help_msg_root); | ||
| /* Dynamically list core plugins in root help */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move all this into a separate function
Summary
This PR updates the root ? help in Radare2 to include a dynamic “Core plugins” section and removes the Lc entry. Users can now discover core plugin commands directly from the main help without relying on Lc.
Changes:
Rationale:
Testing:
Impact:
Resolves #23724